-
Notifications
You must be signed in to change notification settings - Fork 441
add PromiseRejectionEvent from WHATWG Living Standard #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tuures, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
Hi @tuures, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
👍 |
i think it's missing the function getErrorEventText (event: ErrorEvent | PromiseRejectionEvent) {
if (event instanceof ErrorEvent) {
return event.message;
}
// [ts] 'PromiseRejectionEvent' only refers to a type, but is being used as a value here.
if (event instanceof PromiseRejectionEvent) {
return String(event.reason);
}
return "<unknown error>";
} i had to put this in my code (modified from declare var PromiseRejectionEvent: {
prototype: PromiseRejectionEvent;
new(type: string, promiseRejectionEventInitDict?: PromiseRejectionEventInit): PromiseRejectionEvent;
} |
Hi @epicgirl1998 do you mind send another PR to fix this! Help is appreciated. Thank you! |
i would like to contribute but i can't seem to find any documentation for the input json files (how do all the other contributors know what to do? or am i just missing something?) |
The general overview is at https://github.com/Microsoft/TSJS-lib-generator/blob/master/README.md For this case, I think it should be sufficient to add a |
microsoft/TypeScript#10297